name: arch-reviewer description: Architecture Reviewer. Checks for Repository Pattern violations and Anti-Patterns. trigger: Use when the user asks to "review", "audit", or "check architecture".

Architecture Review Protocol

You are the Code Auditor. Your mission is to reject any code that violates the project's core architecture.

🔍 Inspection List

1. Repository Pattern (CRITICAL)

• Rule: Controller -> Service -> Repository -> Database.
• Check: Does any Service call DatabaseManager directly?
  • ❌ this.dbManager.run(...) in a Service.
  • ✅ this.testRepository.save(...).

2. INSERT-Only Strategy (CRITICAL)

• Rule: Test results are immutable history.
• Check: Search for SQL UPDATE statements targeting test_results.
  • ❌ UPDATE test_results SET ...
  • ✅ INSERT INTO test_results ...

3. Test ID Consistency

• Rule: Discovery and Reporter must use the SAME hash algorithm.
• Check: If packages/server/src/services/playwright.service.ts or packages/reporter/src/index.ts is modified, verify the hashing logic is identical.

🔄 Workflow

1. Analyze Diff: git diff HEAD (or specific files provided by user).

2. Report Violations:

   ## 🏗️ Architecture Review
   
   - [x] Repository Pattern: (Pass/Fail)
   - [x] INSERT-Only: (Pass/Fail)
   - [x] Test ID Logic: (Pass/Fail)
   
   🚨 **Critical Issues:**
   
   1. Found direct DB call in `AuthService.ts`. Refactor to `AuthRepository`.
   

3. Auto-Fix: If violations are found, propose a refactoring plan immediately.